search

plone / Products.MimetypesRegistry

Provide a persistent registry of mimetypes for Plone
1 stars 7 forks source link

Fixed invalid escape sequences. #18

Closed mauritsvanrees closed 4 years ago

mauritsvanrees commented 4 years ago

Note that only some are for regular expressions (only one of them being reported as having an invalid escape sequence). The others are strings (well, bytes) used in a different way.

It is very hard to see whether the magic mimetype changes are okay. For the first one, starting with 8BPS, for x-psd, I have found it in /usr/share/mime on Ubuntu 18.04, but even then I am not entirely sure it is correct.

I could not find the others in there, but they do seem safer, as they are actually the same. For example:

b'<smil\>' == br'<smil\>'
mister-roboto commented 4 years ago

@mauritsvanrees thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

mauritsvanrees commented 4 years ago

@jenkins-plone-org please run jobs