search

plone / Products.MimetypesRegistry

Provide a persistent registry of mimetypes for Plone
1 stars 7 forks source link

Introduce python-magic and modernize various places #20

Open pgrunewald opened 3 years ago

pgrunewald commented 3 years ago

Solves #7 and #19

Please let me know, if anything could be done better!

mister-roboto commented 3 years ago

@pgrunewald thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

pgrunewald commented 3 years ago

@jenkins-plone-org please run jobs

pgrunewald commented 3 years ago

I updated the news entries. Some newlines at the EOF were missing - it worked for towncrier however. :shrug:

The tests ran through, except with a single one, that is broken for quite longer (at least 39 days).

@jenkins-plone-org please run jobs

pgrunewald commented 11 months ago

Since some checks are still broken (to reasons unrelated the original change), I will wait for #25.

gforcada commented 11 months ago

I see that tests on Windows fail again and some dependencies need to be solved, you can see that for yourself with:

tox -e dependencies

And probably you will need to tweak some options from https://github.com/plone/meta/tree/main/config#pyprojecttoml

Ask for help if you need it 😄

gforcada commented 11 months ago

As for the Windows test failures, might it be that we need python-magic-bin ? as mentioned on python-magic PyPI page