search

plone / Products.MimetypesRegistry

Provide a persistent registry of mimetypes for Plone
1 stars 7 forks source link

Fix missing comma in install_requires. #21

Closed mauritsvanrees closed 2 years ago

mauritsvanrees commented 2 years ago

This caused the first item to be parsed as:

AccessControl>=3.0.0Acquisition

This resulted in a warning on startup with a recent setuptools:

pkg_resources/_vendor/packaging/specifiers.py:273: DeprecationWarning:
Creating a LegacyVersion has been deprecated and will be removed in the next major release
mister-roboto commented 2 years ago

@mauritsvanrees thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

mauritsvanrees commented 2 years ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 2 years ago

Some Jenkins jobs pass, some not, I am sure they are unrelated. The real test of this change is that buildout finishes without an installation error.

Rudd-O commented 2 years ago

The job failures do not appear related to me.