search

plone / Products.MimetypesRegistry

Provide a persistent registry of mimetypes for Plone
1 stars 7 forks source link

Fix classify() for magic classifier and binary data. #40

Open fdiary opened 1 month ago

fdiary commented 1 month ago

This PR fixes an issue of MimeTypesRegistry.classify() that fails with magic classifier and binary data. #39

mister-roboto commented 1 month ago

@fdiary you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

mister-roboto commented 1 month ago

@fdiary thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

fdiary commented 1 month ago

@gforcada I already signed the agreement on March 31th 2021. For "Changelog verifier" error, shall I manually add an entry in CHANGES.rst ?

gforcada commented 1 month ago

@fdiary sorry for the delay, I've been really busy at work, and did not have time to check github notifications 😖

As for the change log entry, see our documentation about it: https://6.docs.plone.org/contributing/index.html?highlight=news#change-log-entry

Or in short: create a file inside the top-level news folder with a file name like 39.bugfix and a short description (one line) of what you changed 😄

mister-roboto commented 1 month ago

@fdiary you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

fdiary commented 1 month ago

@gforcada Thanks for the information. I just added a changelog entry file. And I already signed the agreement on March 31th 2021.

fdiary commented 1 month ago

@jenkins-plone-org please run jobs

fdiary commented 1 month ago

Anyway I did sign again electronically.

fdiary commented 3 weeks ago

@jenkins-plone-org please run jobs

gforcada commented 2 weeks ago

Seems that something is still off with your contributor agreement... or rather, maybe you need to push the changes again, so that it re-runs? 🤔

mister-roboto commented 2 weeks ago

@fdiary thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

gforcada commented 2 weeks ago

Aha! closing and re-opening the PR did the trick, your contributor agreement now is fine 🎉

gforcada commented 2 weeks ago

@jenkins-plone-org please run jobs