search

plone / plone.scale

Contains image scaling logic for use in Zope environments. It supports Zope 2, Pyramid and other systems build on using the Zope ToolKit (ZTK).
https://pypi.org/project/plone.scale
2 stars 16 forks source link

Pre scale: store non-random uid to prepare space for a scale. #57

Closed mauritsvanrees closed 2 years ago

mauritsvanrees commented 2 years ago

Do not generate the scale yet. Only generate it when a visitor calls the url of the unique scale.

Note: contains various print statements for debugging.

mister-roboto commented 2 years ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!