search

plone / plone.scale

Contains image scaling logic for use in Zope environments. It supports Zope 2, Pyramid and other systems build on using the Zope ToolKit (ZTK).
https://pypi.org/project/plone.scale
2 stars 16 forks source link

Fix KeyErrors in ScalesDict conflict resolution #84

Closed davisagli closed 1 year ago

davisagli commented 1 year ago

Fixes #83

There are a couple cases in the ScalesDict conflict resolution code that can throw a KeyError. This was looking up the current value for debugging purposes, but there are 2 cases where the value is expected to not be there, so we can't look it up.

mister-roboto commented 1 year ago

@davisagli thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

davisagli commented 1 year ago

@jenkins-plone-org please run jobs