plottertools / hatched

Convert images to plotter-friendly hatched patterns
MIT License
95 stars 9 forks source link

Variable number of levels #14

Closed mariana-s-fernandes closed 2 years ago

mariana-s-fernandes commented 2 years ago

Added support for variable number of levels. This option is only available for the library mode and not in the plugin (which continues to accept the fixed number of 3 levels).

mariana-s-fernandes commented 2 years ago

@abey79 Can you please test this with some examples of your own and see if everything works?

jimmykl commented 2 years ago

Hi @mariana-s-fernandes

I would like to test this but have only used the plugin version before and when I try following the instructions for the library python ./examples/skull.py gives me ModuleNotFoundError: No module named 'hatched'

This is the process I used to install/setup:


git clone https://github.com/plottertools/hatched.git
cd hatched
git fetch origin pull/14/head:MASTER
python3 -m venv venv
source venv/bin/activate
pip install -r requirements.txt
mariana-s-fernandes commented 2 years ago

Hi @jimmykl , my changes should not have impacted that process. But this error has to do with the weird way that Python deals with paths. I don't remember the exact right way to deal with this (I think there is something that needs to be added to the PYTHONPATH env variable or something like that), but in the short term, copy the skull.py out of the examples folder and it should work.

abey79 commented 2 years ago

Looks good to me, please check my two comment.

mariana-s-fernandes commented 2 years ago

hi @abey79 , fixed the comments above

abey79 commented 2 years ago

Looks good, thanks!