search

plusone-robotics / moveit_simple

A wrapper around MoveIt that enables more traditional industrial robot programming.
Apache License 2.0
15 stars 12 forks source link

Reason for using plusone fork of rosparam_handler? #31

Closed gavanderhoorn closed 6 years ago

gavanderhoorn commented 6 years ago

Afaict all changes added in https://github.com/plusone-robotics/rosparam_handler/commit/5e511fb95b2d3dac163aec91c9925068dc55e628 are already (?) present upstream.

gavanderhoorn commented 6 years ago

Using upstream would allow for removing the source dep from the .rosinstall file (with similar benefits as #32).

shaun-edwards commented 6 years ago

When i forked it, there wasnt a debian. Im not sure if there is one now. As a rule PlusOne will fork any project that may not be stable. This ensures we aren't tracking down problems due to changes upstream. As we move towards a ROS release, these upstream dependencies will need to be addressed.

gavanderhoorn commented 6 years ago

@shaun-edwards wrote:

When i forked it, there wasnt a debian. Im not sure if there is one now.

There are.

As a rule PlusOne will fork any project that may not be stable. This ensures we aren't tracking down problems due to changes upstream.

An alternative might be to use a .rosinstall file with a specific commit as version instead of master or some other default branch. That way you don't need to fork and are still using a specific version.