Eigen includes should not contain version prefix

plusone-robotics / moveit_simple

A wrapper around MoveIt that enables more traditional industrial robot programming.

Apache License 2.0

15 stars 12 forks source link

Eigen includes should not contain version prefix #33

Open gavanderhoorn opened 6 years ago

gavanderhoorn commented 6 years ago

The current #includes seem to have the eigen3 part included:

https://github.com/shaun-edwards/moveit_simple/blob/2bcca7d855c199883963c81b4f6668b060533401/moveit_simple/include/moveit_simple/moveit_simple.h#L28

That is rather unusual, and will limit future compatibility with (if it ever gets released) v4 of Eigen.

Was this done to work around incorrectly setup include paths (ie: only /usr/include on the path)?

MauleshSTrivedi commented 6 years ago

@gavanderhoorn Good catch. It was definitely a part of an old commit, but I'm not sure why this was done specifically. I can make the necessary changes once I have more information regarding this.