search

plusone-robotics / moveit_simple

A wrapper around MoveIt that enables more traditional industrial robot programming.
Apache License 2.0
15 stars 12 forks source link

Fixed problem where build was failing locally #46

Closed geoffreychiou closed 6 years ago

geoffreychiou commented 6 years ago

Build was failing locally on some machines, this fixes that.

@gomezc please review.

gomezc commented 6 years ago

@geoffreychiou looks like something is breaking - the Travis CI build failed on 125.1 (for Indigo). Otherwise, I agree with the changes in the two files.

geoffreychiou commented 6 years ago

@geoffreychiou looks like something is breaking - the Travis CI build failed on 125.1 (for Indigo). Otherwise, I agree with the changes in the two files.

@gomezc build passed but tests failed. I believe @MauleshSTrivedi is working on getting that fixed in his next pull request. I don't believe the changes in this PR should have any effect on tests passing/failing so i'll leave it up to @shaun-edwards to merge or wait.

gomezc commented 6 years ago

sounds good to me

MauleshSTrivedi commented 6 years ago

believe @MauleshSTrivedi is working on getting that fixed in his next pull request.

yup, I will be getting back on this as soon as possible.