Closed geoffreychiou closed 6 years ago
@geoffreychiou, please add appropriate tests for this new functionality.
At a high level, it feels like you added more functionality than was needed to achieve our use case. What else is required beyond the code snippet below
robot.beginExecute("some_traj");
while (robot.isExecuting())
{
//check OK conditions
if (not_ok)
{
robot.abortExecution()
}
}
What else is required beyond the code snippet below
Beyond that, we check for the timeout of the execution locally and just because we call stopExecution() doesn't mean the execution stops immediately, so if I were to add another motion right after it causes problems.
What is the use case for checkGoalInCollision
, if it isn't needed in the code snippet above.
What is the use case for checkGoalInCollision, if it isn't needed in the code snippet above.
It is used as privately, but I left it as public in case someone wanted to use it.
@joshuaplusone please review.
@joshuaplusone I made the changes you requested.
TODO