plusone-robotics / moveit_simple

A wrapper around MoveIt that enables more traditional industrial robot programming.
Apache License 2.0
15 stars 12 forks source link

Added non blocking execution call for online robot #59

Closed geoffreychiou closed 6 years ago

geoffreychiou commented 6 years ago

TODO

shaun-edwards commented 6 years ago

@geoffreychiou, please add appropriate tests for this new functionality.

At a high level, it feels like you added more functionality than was needed to achieve our use case. What else is required beyond the code snippet below


robot.beginExecute("some_traj");
while (robot.isExecuting())
{
  //check OK conditions
  if (not_ok)
  {
    robot.abortExecution()
  }
}
geoffreychiou commented 6 years ago

What else is required beyond the code snippet below

Beyond that, we check for the timeout of the execution locally and just because we call stopExecution() doesn't mean the execution stops immediately, so if I were to add another motion right after it causes problems.

shaun-edwards commented 6 years ago

What is the use case for checkGoalInCollision, if it isn't needed in the code snippet above.

geoffreychiou commented 6 years ago

What is the use case for checkGoalInCollision, if it isn't needed in the code snippet above.

It is used as privately, but I left it as public in case someone wanted to use it.

geoffreychiou commented 6 years ago

@joshuaplusone please review.

geoffreychiou commented 6 years ago

@joshuaplusone I made the changes you requested.