search

plusone-robotics / moveit_simple

A wrapper around MoveIt that enables more traditional industrial robot programming.
Apache License 2.0
15 stars 12 forks source link

moveit_simple_msgs package is missing install rule #76

Closed 130s closed 5 years ago

130s commented 5 years ago

@geoffreychiou found it.

Not sure yet though, why on CI for PRs passed (e.g. this for https://github.com/plusone-robotics/moveit_simple/pull/75) without install rules as industrial_ci by default uses only install space.

geoffreychiou commented 5 years ago

I actually don't see CI running anymore on github, did it get removed?

130s commented 5 years ago

I do see CI ran for the last several MRs.
screenshot from 2019-02-18 15-30-06

Where are you looking at @geoffreychiou?

geoffreychiou commented 5 years ago

Nevermind, github must have changed the UI, it used to say "All checks passed" with a green icon in the the PR.

130s commented 5 years ago

I didn't know this! Good learning. http://docs.ros.org/kinetic/api/catkin/html/howto/format2/building_msgs.html

Since catkin installs message, service and action targets automatically, no extra install() commands are needed for them.