search

plwalters / aurelia-bs-modal

DEPRECATED - Aurelia plugin for bootstrap modal
MIT License
17 stars 16 forks source link

implements #16 - allows passing optional escape handler #34

Open atsu85 opened 8 years ago

plwalters commented 8 years ago

@atsu85 Need some tests to back up this behavior can you please add some? I'll gladly take your word that this fixes the issues if you have some tests to back it up ;) As a note we have the aurelia-dialog plugin library that I am helping to maintain at the moment so I don't focus on this one as much at the moment so thanks for the help.

atsu85 commented 8 years ago

@PWKad do You mean end-to-end test? Currently as i understand there are no tests in this project and the foundation is missing for it. Considering that

we have the aurelia-dialog plugin library that I am helping to maintain at the moment so I don't focus on this one as much at the moment

and that probably aurelia-dialog plugin should be first choice for the next project, I'd prefer to not spend too much time on it - what do You think?