search

plwalters / aurelia-bs-modal

DEPRECATED - Aurelia plugin for bootstrap modal
MIT License
17 stars 16 forks source link

Can bind the model in addition to the view #6

Closed lipsitzm closed 9 years ago

lipsitzm commented 9 years ago

I've tried it out both passing and not passing a model and had no issues either way... Let me know how it looks!

plwalters commented 9 years ago

@lipsitzm Thanks for this! Looks great except for one small thing - the content_view and content_model attributes should follow the convention of being dasherized instead of snake cased. Can you fix this and push that change out and I will merge?

plwalters commented 9 years ago

I've had to merge this in to develop to fix, your commits will exist in history (and I greatly appreciate them) but I'll need to close this PR.