search

pmmmwh / react-refresh-webpack-plugin

A Webpack plugin to enable "Fast Refresh" (also previously known as Hot Reloading) for React components.
MIT License
3.13k stars 193 forks source link

feat: add @rspack/core as an optional peer dependency #785

Closed chenjiahan closed 9 months ago

chenjiahan commented 10 months ago

Background

Rspack is a fast Rust-based web bundler and it is compatible with the architecture and ecosystem of webpack.

The react-refresh-webpack-plugin can be used with Rspack, but users will get a peer dependency warning:

 WARN  Issues with peer dependencies found
.
    └─┬ @pmmmwh/react-refresh-webpack-plugin 0.5.10
      └── ✕ missing peer webpack@">=4.43.0 <6.0.0"

Description

This PR adds @rspack/core as an optional peer dependency, and make webpack as an optional peer dependency too.

Related issues

chenjiahan commented 10 months ago

@pmmmwh Hi, If you have the time, could you review and provide some feedback 😄

pmmmwh commented 4 months ago

Hey, sorry that I couldn't give this a proper look previously - if the RSPack team is still interested in this I am willing to land this change in the next version 0.6.x