Allow v5 of `webpack-dev-server` as peer dependency

pmmmwh / react-refresh-webpack-plugin

A Webpack plugin to enable "Fast Refresh" (also previously known as Hot Reloading) for React components.

MIT License

3.13k stars 192 forks source link

Allow v5 of `webpack-dev-server` as peer dependency #836

Closed mxdvl closed 4 months ago

mxdvl commented 4 months ago

Release notes v5.0.0 along with the migration guide.

The Node version of the consumer is not a concern of this package
The webpack and webpack-cli of the consumer are not a concern of this package
The http & https options are not used internally

Should we also bump the local dev dependency on webpack-dev-server to v5?

codesandbox[bot] commented 4 months ago

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders
Open Preview

pmmmwh commented 4 months ago

Should we also bump the local dev dependency on webpack-dev-server to v5?

I think we should, just to make sure tests pass. If that can be done I'm happy to cut this release first then work towards moving completely over to v5 👍🏻

pmmmwh commented 4 months ago

Fixes #787 Fixes #800 Fixes #824

mxdvl commented 4 months ago

@pmmmwh I’ve tried and failed to make CI pass:

the minimum Node version is 18.12, and it seems your current puppeteer image is 18.9, so that fails for webpack 4 and webpack 5
the test server is also failing to run… I am experiencing the same thing locally and feel like I am not familiar enough with the project to make this work