search

pmndrs / drei

🥉 useful helpers for react-three-fiber
https://docs.pmnd.rs/drei
MIT License
8.38k stars 699 forks source link

Allow for the sdfGlyphSize option on Text #1339

Open atlmtw opened 1 year ago

atlmtw commented 1 year ago

Describe the feature you'd like:

troika-three-text allows adjusting glyph size that the text uses as a texture (to calculate distance fields). However the implementation in drei doesn't accept glyph size as a prop. Understandably because this isn't something you would want constantly changed on state change.

Why would adding sdfGlyphSize be beneficial? In some cases increasing glyph size may increase sharpness and decreasing glyph size would decrease memory usage. It gives the user more control and makes the troika-three-text implementation more 1 : 1.

Suggested implementation:

Could we suggest adding it as a prop that is only valid after one time use? It does sound a bit hacky but open to other suggestions as well.

drcmda commented 1 year ago

it spreads all rest props over the instance so most likely it does support it even if types don't include it. try it, and please make a pR for that type if it's missing.

github-actions[bot] commented 1 week ago

Thank you for contributing! We’re marking this issue as stale as a gentle reminder to revisit it and give it the attention it needs to move forward.

Any activity, like adding an update or comment, will automatically remove the stale label so it stays on our radar.

Feel free to reach out on Discord if you need support or feedback from the community. This issue will close automatically soon if there’s no further activity. Thank you for understanding and for being part of the project!