`<Instances>` seems to have a hard-coded limit of 1000 instances

[gewesp]

• three version: not relevant
• @react-three/fiber version: not relevant
• @react-three/drei version: current
• node version: not relevant
• npm (or yarn) version: not relevant

Problem description:

<Instances> hard-codes max number of instances to 1000. We ran into a problem with more child objects silently being dropped.

Relevant code:

https://github.com/pmndrs/drei/blob/master/src/core/Instances.tsx#L108

Suggested solution:

Use children.length as the default?

[isaac-mason]

You can change the default with the limit prop.

e.g.

<Instances limit={10000} {/* ... other props ... */} >
  {/* ... */}
</Instances>

See: https://github.com/pmndrs/drei/blob/master/src/core/Instances.tsx#L24

[gewesp]

You can change the default with the limit prop.

Thanks, we had figured that already. Still, I see no good reason why it should specifically be limited to 1000 and it definitely should not silently drop more instances.