search

pmndrs / drei

🥉 useful helpers for react-three-fiber
https://drei.pmnd.rs/
MIT License
7.85k stars 641 forks source link

docs: Correct error in PerformanceMonitor example snippet #1912

Open bevanmw opened 2 months ago

bevanmw commented 2 months ago

Corrected example which was passing a second parameter to Math.floor() which only takes one parameter.

Why

The code in the documentation is incorrect. Math.floor() only takes in one element. This change corrects the error and modifies the logic to work without error.

What

Documentation was corrected - and follows the documentation hosted here: https://docs.pmnd.rs/react-three-fiber/advanced/scaling-performance. However, the documentation there has a dependancy on lodash - this change does not introduce the dependancy but rather manually applies the calculation to round to a precision of 1 digit after the decimal.

Checklist

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 7:53pm
codesandbox-ci[bot] commented 2 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.