search

pmndrs / drei

🥉 useful helpers for react-three-fiber
https://drei.pmnd.rs/
MIT License
7.85k stars 641 forks source link

Fix callback type of `onChanged` prop in `<CycleRaycast />` #1927

Open lr0pb opened 2 months ago

lr0pb commented 2 months ago

Why

I found strange that event callback type in <CycleRaycast /> component needed to return null instead more suitable in this case void

What

Change onChanged callback type in <CycleRaycast /> component to return void instead of null. Also copy <CycleRaycast /> props descriptions from official docs into JSDoc annotations & fix JSDoc annotations for <DragControls /> component

Checklist

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 1:20pm
codesandbox-ci[bot] commented 2 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.