search

pmndrs / drei

🥉 useful helpers for react-three-fiber
https://docs.pmnd.rs/drei
MIT License
8.23k stars 675 forks source link

[feat] update for R3F v9 #1941

Open krispya opened 4 months ago

krispya commented 4 months ago

This is untested. It is a quick conversion of Drei v9 to use R3F v9 without any typing errors.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 6:40pm
krispya commented 4 months ago

@joshuaellis I'd like to appeal to you about upgrading react-spring for R3F v9. :)

codesandbox-ci[bot] commented 4 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

krispya commented 4 months ago

Now builds. Known issues are with components that access R3F internals like RenderTexture.

joshuaellis commented 4 months ago

@joshuaellis I'd like to appeal to you about upgrading react-spring for R3F v9. :)

Sorry I missed this. Do you know what the impact looks like? I can probably find some time for you haha

krispya commented 4 months ago

@joshuaellis I'd like to appeal to you about upgrading react-spring for R3F v9. :)

Sorry I missed this. Do you know what the impact looks like? I can probably find some time for you haha

I believe it is just types, maybe related to this: https://react.dev/blog/2024/04/25/react-19-upgrade-guide#the-jsx-namespace-in-typescript

We also moved types for R3F to ThreeElements.

krispya commented 4 months ago

@CodyJasonBennett I'm stuck again getting the test to run. Some kind of source map issue.