fix: useTexture callback parameter and behavior

pmndrs / drei

🥉 useful helpers for react-three-fiber

https://drei.pmnd.rs/

MIT License

7.83k stars 642 forks source link

fix: useTexture callback parameter and behavior #1970

Open jwueller opened 1 month ago

jwueller commented 1 month ago

Why

Fixes #1968 Fixes #1969

What

Fixes the behavior of the useTexture(..., onLoad) callback according to the declared types, as well as the conditions under which it is fired (i.e. when the data changes, not when the function does).

Checklist

[ ] Documentation updated (example)
[ ] Storybook entry added (example)
[x] Ready to be merged

No documentation or storybook change is required, because this just fixes previously-documented behavior.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
drei	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 30, 2024 6:35pm

codesandbox-ci[bot] commented 1 month ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.