fix: restore Edge component to accept geometry as prop

pmndrs / drei

🥉 useful helpers for react-three-fiber

https://drei.pmnd.rs/

MIT License

7.83k stars 642 forks source link

fix: restore Edge component to accept geometry as prop #1978

Closed nickthegroot closed 1 week ago

nickthegroot commented 4 weeks ago

Why

fixes #1893

A previous refactor of the <Edges> component made it so that passing geometry as a prop no longer worked. This is a breaking change for many users that prevented upgrading.

What

This PR restores the expected behavior from the README:

It pulls the geometry automatically from its parent, optionally you can ungroup it and give it a geometry prop. https://github.com/pmndrs/drei?tab=readme-ov-file#edges

Checklist

[X] Ready to be merged

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
drei	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 3, 2024 10:40pm

codesandbox-ci[bot] commented 4 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

github-actions[bot] commented 1 week ago

:tada: This PR is included in version 9.107.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: