pmndrs / drei

🥉 useful helpers for react-three-fiber
https://drei.pmnd.rs/
MIT License
7.83k stars 642 forks source link

fix: 1966 View respects manual ortho camera #1991

Open talkingtab opened 3 weeks ago

talkingtab commented 3 weeks ago

Why

View.tsx is changed for bug #1966. A the frustum of an orthographic camera was reset to the default position even when the camera was manual. The user's manual setting (for example to do a full-frame view) was thus overwritten.

What

After checking that the camera is Orthographic, the code now checks if state.camera.manual is set. If not the old code is executed. Otherwise just update the projection matrix. NOT SURE THIS IS NEEDED

Checklist

Not sure what the right next step is.

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 9:05pm
codesandbox-ci[bot] commented 3 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.