search

pmndrs / drei

🥉 useful helpers for react-three-fiber
https://docs.pmnd.rs/drei
MIT License
8.44k stars 708 forks source link

Add LUT presets #211

Open gsimone opened 3 years ago

gsimone commented 3 years ago

Much like environments and matcap textures, add an easy way to get LUTs for quick prototyping

LUT Example for three.js https://threejs.org/examples/?q=lut#webgl_postprocessing_3dlut

  1. Download three's example LUTs
  2. Rehost them on github ( you can use PR this repository https://github.com/mattrossman/drei-assets )
jbixon13 commented 3 years ago

are you saying the PR should be opened on mattrossman/drei-assets instead of drei? Or to copy that repo in a PR here?

drcmda commented 3 years ago

i think poimandres should host all these assets

gsimone commented 3 years ago

@drcmda Eventually yes, we should make a repo with all the prototyping assets and transfer matt's one to pmdnrs @jbixon13 no, the actual LUT files should live in something like matt's repository, the code to load and select them is in drei - much like useNormalTexture, useMatcapTexture and Environment

We are not putting all these assets in drei to avoid bloating the repo

joshuaellis commented 3 years ago

@gsimone do we still need this open? If so, what are the next steps so someone can pick it up? 👍🏼

jbixon13 commented 3 years ago

A component is still needed to load the LUT to the scene from the repo that hosts the LUTs. I was going to try making one within the next week or so.

Also not sure what the timeframe of those assets being hosted under pmndrs is, I'll plan on linking to matt's repo for now

Edit: sorry didn't see that was tagged to someone

joshuaellis commented 3 years ago

sounds great @jbixon13 feel free to shout on discord or create a draft PR if you need any support.

github-actions[bot] commented 3 weeks ago

Thank you for contributing! We’re marking this issue as stale as a gentle reminder to revisit it and give it the attention it needs to move forward.

Any activity, like adding an update or comment, will automatically remove the stale label so it stays on our radar.

Feel free to reach out on Discord if you need support or feedback from the community. This issue will close automatically soon if there’s no further activity. Thank you for understanding and for being part of the project!