search

pmndrs / drei

🥉 useful helpers for react-three-fiber
https://docs.pmnd.rs/drei
MIT License
8.36k stars 699 forks source link

useDetectGPU pointing to 3.x version #717

Open liqueflies opened 2 years ago

liqueflies commented 2 years ago

Problem description:

Hello, the function useDetectGPU is pointing to a 3.x version on dependencies so it's not working good to iPhone, M1 chips etc... detect-gpu is now at 4.x version

Suggested solution:

Just update the version on the dependency list! For now I installed the fresh version of detect-gpu and copied the drei useDetectGPU file into my utils.

Thank you!

joshuaellis commented 2 years ago

Feel free to make a PR to address this issue 😄

liqueflies commented 2 years ago

👍 Is good to put dependencies as "latest" as is maintained by pmndrs?

joshuaellis commented 2 years ago

I wouldn't just incase there's a breaking change (e.g. v5) that we haven't seen. PMNDRS is a very large org, we're not watching all repos!

CodyJasonBennett commented 2 years ago

The v4 bump came from https://github.com/pmndrs/detect-gpu/commit/00b4c619b5a822ab0b009c9ca87ad0726be48c67. Doesn't look like anything as far as the public API changed.

github-actions[bot] commented 2 days ago

Thank you for contributing! We’re marking this issue as stale as a gentle reminder to revisit it and give it the attention it needs to move forward.

Any activity, like adding an update or comment, will automatically remove the stale label so it stays on our radar.

Feel free to reach out on Discord if you need support or feedback from the community. This issue will close automatically soon if there’s no further activity. Thank you for understanding and for being part of the project!