search

pmndrs / drei

🥉 useful helpers for react-three-fiber
https://docs.pmnd.rs/drei
MIT License
8.36k stars 699 forks source link

GizmoHelper axis head rotation snaps the camera to an incorrect alignment with TrackballControls #962

Open discosultan opened 2 years ago

discosultan commented 2 years ago

Problem description:

When using GizmoHelper with TrackballControls, if the camera is moved from its' default location, using the GizmoHelper axis head to automatically rotate the camera ends up misaligning the camera. See the gif below: gizmohelper

The issue can be reproduced in the storybook: https://drei.pmnd.rs/?path=/story/gizmos-gizmohelper--gizmo-helper-story&args=controls:TrackballControls

Steps:

  1. Rotate the camera around the object arbitrarily holding mouse left button
  2. Click on one of the GizmoHelper axis heads to align camera to a specific direction

I was not able to reproduce the issue with OrbitControls.

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 9.17.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

FarazzShaikh commented 2 years ago

Reopening as there still seems to be some inconsistant jank when snapping from -x to -y

FarazzShaikh commented 2 years ago

Might be related with #522

github-actions[bot] commented 2 days ago

Thank you for contributing! We’re marking this issue as stale as a gentle reminder to revisit it and give it the attention it needs to move forward.

Any activity, like adding an update or comment, will automatically remove the stale label so it stays on our radar.

Feel free to reach out on Discord if you need support or feedback from the community. This issue will close automatically soon if there’s no further activity. Thank you for understanding and for being part of the project!