search

pmwisdom / meteor-background-geolocation-services

Cordova Background Geolocation For Android and iOS with pure javascript callbacks
12 stars 12 forks source link

Meteor 1.6 build fails #12

Open davinderkumar opened 6 years ago

davinderkumar commented 6 years ago

Hi

After upgrading to Meteor 1.6, build fails due to this plugin

%% Failed to install 'org.flybuy.cordova.background-location-services': Error: Cannot find module '../plugman/platforms/ios'

While adding plugin https://github.com/pmwisdom/cordova-background-geolocation-services.git#8a3041eb102e7926f5d4d4f4df29fa72dcdaea62 to Cordova project: Error: Cannot find module '../plugman/platforms/ios'

I upgraded Cordova to 8.0 as well but no success.

a fix for this will be helpful.

thanks

davinderkumar commented 6 years ago

@pmwisdom can you please look into this?

pmwisdom commented 6 years ago

I unfortunately don't have a mac to fix this on currently, nor the time.

PR welcome though.

davinderkumar commented 6 years ago

@pmwisdom Oh. I have spent some more time in analysing the issue and found that this issue is happening from meteor 1.5.2 onwards as Cordova was updated to 7.x Will you be able to fix this in near future or moving away to another plugin is only painful option?

pmwisdom commented 6 years ago

I did a quick search for you, this seems to be the problem.

https://github.com/ionic-team/ionic-plugin-deeplinks/issues/99

So basically the hook script here https://github.com/pmwisdom/cordova-background-geolocation-services/blob/master/hooks/add_swift_support.js. Is looking for the wrong path, which doesn't exist in 7.0 anymore.

It looks like there is a workaround, but I don't have a mac to test it out on right now, and you might be able to figure it out since its just JavaScript.

If you try and cant get it to wor I'll try to apply the fix in a branch and you can test it.

davinderkumar commented 6 years ago

@pmwisdom I have found the issue.

Actually this bug was already fixed in commit Commit but you did not update the dependency commit in meteor plugin package.js

Can you please modify line 15 to

"org.flybuy.cordova.background-location-services" : "https://github.com/pmwisdom/cordova-background-geolocation-services.git#ba0383667fe4d64887e9d7cf141ddacf1a0218d2"

and push the plugin to atmosphere?

I have tested this fix on my mac with a local copy of plugin.

Thanks, Davinder

davinderkumar commented 6 years ago

also update cordova-plugin-geolocation to 4.0.1