pnp / custom-learning-office-365

Microsoft Learning Pathways end user learning solution for Microsoft 365 customers.
MIT License
228 stars 209 forks source link

Pages in the learning pathways are being truncated #728

Closed RogEMC closed 1 year ago

RogEMC commented 1 year ago

PROVISIONING NOTE: If you are having issues with the SharePoint look book while trying to provision M365 learning pathways please do not post that issue to this repo as we cannot help you here. Please post all questions and issues for the SharePoint look book to SharePoint/sp-provisioning-service GitHub Issues List.

WEB PART NOT LOADING: If you are getting the error: "Microsoft 365 learning pathways has a configuration issue. Ask your administrator for assistance". Please review the Diagnosing Pre-Check guidance before submitting your bug.

Describe the bug

Pages in the learning pathways are being truncated i.e., users can't scroll to the bottom of the page when there is more scrolling required because there is more content.

Just for reference I tried:

To Reproduce

I added content by going to Playlist Assets then adding a URL such as https://support.microsoft.com/en-au/office/sharing-files-folders-and-list-items-74cab0bf-39c6-4112-a63f-88ee121722d0?ns=spostandard&version=16&syslcid=3081&uilcid=3081&appver=spo160&helpid=wssenduser_odspsharingoptions_fl846149&ui=en-us&rs=en-au&ad=au)

Expected behavior

A clear and concise description of what you expected to happen. Users should be able to scroll down to the bottom of the page.

Screenshots

This is the start of the page image

However, when I scroll down to the bottom, the some of the content isn't there.

image

If applicable, add screenshots to help explain your problem.

Learning Pathways version number

Please share the version number of learning pathways in your tenant app catalog.

Additional context

Add any other context about the problem here.

juliemturner commented 1 year ago

Unfortunately this is an issue that isn't really something we can "fix" but I can enhance it somewhat to make more content fit more readily. The default height of the iFrame for content that doesn't have the ability to report to the parent window what it's height is. I will double the default height for this area from 6000px to 12000px and that will help, but won't necessarily fix it every time.

RogEMC commented 1 year ago

Thanks Julie. When should the change to the iFrame take effect? I have looked at some pages which were being truncated before and they are still stopping at the same point (per below screenshot). I have cleared my cache just in case.

image

dcashpeterson commented 1 year ago

@RogEMC I have merged in the fix for this. You can update your package to the latest version.

github-actions[bot] commented 1 year ago

This issue is locked for inactivity or age. If you have a related issue please open a new issue and reference this one. Closed issues are not tracked.