search

pnp / custom-learning-office-365

Microsoft Learning Pathways end user learning solution for Microsoft 365 customers.
MIT License
225 stars 207 forks source link

External users unable to view content #765

Closed TylerTweedy closed 5 months ago

TylerTweedy commented 5 months ago

PROVISIONING NOTE: If you are having issues with the SharePoint look book while trying to provision M365 learning pathways please do not post that issue to this repo as we cannot help you here. Please post all questions and issues for the SharePoint look book to SharePoint/sp-provisioning-service GitHub Issues List.

WEB PART NOT LOADING: If you are getting the error: "Microsoft 365 learning pathways has a configuration issue. Ask your administrator for assistance". Please review the Diagnosing Pre-Check guidance before submitting your bug.

Describe the bug

A Teams group has been added to a SharePoint Site. Within the Teams group, internal users have various permissions and ALL external users have visitor permissions. All internal users with visitor permissions are able to view M365LP content while all external users are unable to view M365LP content.

To Reproduce

Adding external users to a Teams group and then adding the Teams group to a SharePoint Site.

Expected Behavior

All members of the Teams group should be able to view all content within the associated SharePoint Site.

Screenshot

External Visitor View image Internal Visitor View image

Learning Pathways version number

4.3.0.0

Additional context

Add any other context about the problem here.

dcashpeterson commented 5 months ago

@TylerTweedy If you need assistance with Learning Pathways please fill out the rest of the information in the issue template so we can diagnose things better. We can't assist with a title only.

TylerTweedy commented 5 months ago

@dcashpeterson Just filled out the rest of the rest of the form. Hopefully this helps.

dcashpeterson commented 5 months ago

@TylerTweedy ahhhh, ok. This makes a lot of sense. The challenge here isn't a Learning Pathways issue it's a security issue with the App Catalog where the code for Learning Pathways lives in your tenant. The reason that internal users can see the webpart is that All Users Except for External has read only access to the app catalog. To fix this you (or an admin in your tenant) would need to ensure that the All Users group has read access to the app catalog. Alternately you can also turn on the public CDN.

You can also check out issue #740. Specifically this comment

TylerTweedy commented 5 months ago

@dcashpeterson Thanks Derek, you're the man! I don't have access to that and had a feeling it was something our IT admin would need to address but I was hoping I could be proactive and handle it myself. On a side note, will M365LP be retired as part of the "add-in" retirements on April 2, 2026?

dcashpeterson commented 5 months ago

@TylerTweedy no problem. Happy to help and I love that folks are using Microsoft 365 Learning Pathways. To answer your question about SharePoint Add-In model. M365 Learning Pathways is created as a webpart using SPFx. It was not created using the Add-In model so it will be unaffected. Closing this issue as answered. If you have any other questions feel free to open another issue.

github-actions[bot] commented 4 months ago

This issue is locked for inactivity or age. If you have a related issue please open a new issue and reference this one. Closed issues are not tracked.