pnp / custom-learning-office-365

Microsoft Learning Pathways end user learning solution for Microsoft 365 customers.
MIT License
246 stars 218 forks source link

PnP authentication update required for installation/M365lpConfiguration.ps1 #854

Open smiddles opened 1 month ago

smiddles commented 1 month ago

PROVISIONING NOTE: If you are having issues with the SharePoint look book while trying to provision M365 learning pathways please do not post that issue to this repo as we cannot help you here. Please post all questions and issues for the SharePoint look book to SharePoint/sp-provisioning-service GitHub Issues List.

WEB PART NOT LOADING: If you are getting the error: "Microsoft 365 learning pathways has a configuration issue. Ask your administrator for assistance". Please review the Diagnosing Pre-Check guidance before submitting your bug.

Describe the bug

Unable to authenticate to a SharePoint Online tenant. September 2024 updates to authentication of PnP Powershell and the requirement for a Client ID to be used is not currently configured in the installation/M365lpConfiguration.ps1 script.

To Reproduce

Execute script, enter valid admin credentials (to SharePoint Admin).

Expected behavior

Continue script creation of pages to nominated Learning Pathways communication site

Screenshots

If applicable, add screenshots to help explain your problem.

Learning Pathways version number

Please share the version number of learning pathways in your tenant app catalog.

Additional context

Add any other context about the problem here.

dcashpeterson commented 1 month ago

@smiddles Thanks for bringing this to our attention. What would your expectation be for the edit to the script? Would you expect a parameter for client ID or something else?

smiddles commented 1 month ago

Thanks Derek. Adding a variable declaration at the top for the ClientID, which is then applied in the instances of Connect-PnPOnline if declared?


From: Derek Cash-Peterson @.> Sent: Tuesday, 22 October 2024 2:28 AM To: pnp/custom-learning-office-365 @.> Cc: Steve Middleton @.>; Mention @.> Subject: Re: [pnp/custom-learning-office-365] PnP authentication update required for installation/M365lpConfiguration.ps1 (Issue #854)

@smiddleshttps://github.com/smiddles Thanks for bringing this to our attention. What would your expectation be for the edit to the script? Would you expect a parameter for client ID or something else?

— Reply to this email directly, view it on GitHubhttps://github.com/pnp/custom-learning-office-365/issues/854#issuecomment-2427156620, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BMG22XTIGUT6OS5RHA2ZFR3Z4UTSDAVCNFSM6AAAAABQE6H7A6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRXGE2TMNRSGA. You are receiving this because you were mentioned.Message ID: @.***>