search

poap-xyz / poap-qr-kiosk

MVP of a QR claim code kiosk
13 stars 11 forks source link

Bugfix/flaky test break iterable symbol #153

Closed actuallymentor closed 11 months ago

actuallymentor commented 11 months ago

WIP

github-actions[bot] commented 11 months ago

Visit the preview URL for this PR (updated for commit 0378dff):

https://qr-kiosk-dev--pr153-bugfix-flaky-test-br-tipioudk.web.app

(expires Thu, 07 Dec 2023 12:08:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2f5ca7ecd33508df1c3847295db053bb3195c8bc

actuallymentor commented 11 months ago

Ok, so for context @arvee-init: the memory management of the functions was not optimised enough causing unpredictable out-of-memory issues.

I walked through the production Kiosk metrics and set the memory of all functions with custom memory settings to about double of what they used historically.

I'l also looking at better alerting so we get a ping when functions run out of memory of time so we can adjust accordingly.