poblabs / weewx-belchertown

A clean and modern weewx skin with real time streaming updates, forecast data and interactive charts. View it in action at BelchertownWeather.com
https://belchertownweather.com
GNU General Public License v3.0
211 stars 112 forks source link

Translation #104

Closed olpayras closed 5 years ago

olpayras commented 5 years ago

I used skin.conf to translate your skin in french. There are very few fields who stay in english. Here are them.

Main Page

Records

poblabs commented 5 years ago

Those get changed in weewx.conf under Labels > Generic. That is a weewx wide setting.

poblabs commented 5 years ago

Oops I didn't see the word "ending" and "days". I will update that soon.

Barometer, dew point, etc. are in weewx.conf Labels

olpayras commented 5 years ago

Also in the first picture : "Updated on" is also written in index.html.tmpl

// MQTT Websockets not enabled, update the Last Updated timestamp with moment.js
            updated = moment.unix( $current.dateTime.raw ).utcOffset($moment_js_utc_offset).format("LL, LTS");
            updated_text = "**Last Updated** " + updated;
            jQuery(".updated").html( updated_text );
            #end if

When i change bold value it translate.

bonjour81 commented 5 years ago

@olpayras , I would be happy to see your work, I also work on a french version :+1: mine is now online here Oh my god, nous sommes voisins :)

olpayras commented 5 years ago

Hi bonjour81,

Yes we are "voisins". I just translated it to see what wasn't translated. It's not perfect. My station including history feature is here.

My fork for french translation is here too

Have a good day.

Olivier.

bonjour81 commented 5 years ago

Merci @olpayras ! I improved a few translations based on yours. My version is here (translation branch). feel free to contact me if you like to discuss about it (I have a twitter link on my profile). Here is not the place for discussions about translations :)

HoracioDos commented 5 years ago

Hello! It would be a good opportunity to translate into spanish too. I'm a little worried about the page layout. Latin derived languages seems to have longer words, at least in spanish compared to english. I wouldn't like to modify the style sheet to make room for them.

olpayras commented 5 years ago

Yes words are longer in latin derived languages. Anyway, you can truncate some too long words, but I didn't. French has very long words too. You can check on my page. I understand little spanish cause i'm not very far from spain, but cannot help you for translation, cause my spanish writing is too poor.

@Bonjour81, I have no twitter account but have skype account, so we can share ideas for translations or anyelse. My skype account is my nickname here.

HoracioDos commented 5 years ago

Hello Pat I updated to version 1.0RC7 last night and I began to translate into spanish. Station max and min temp labels are the same for snapshots max and min temp. I think it could be better if they are separated. Keywords are "high" and "low" in skin.conf Thanks!

bonjour81 commented 5 years ago

Hello @poblabs , I would like to report a missing key for translation. On record page, just right to "Consecutive Days With Rain" & "Consecutive Days Without Rain", there is "ending". I think "ending" has no translation key in skin.conf. By the way, is there any reason that the construction of this part is different to "all time" on same line ? (no "ending" for alltime).

ending

bonjour81 commented 5 years ago

Same place (juste left to red marking), it is also "days" that is hard coded. There is a coding for day/days (week, weeks etc...) in weewx.conf..maybe we can use this ?

olpayras commented 5 years ago

Hi Bonjour81,

I already reported these mistakes on the first post of this topic. Pat told me, he will update this file sooner. I don't think it's a good idea to use weewx.conf cause when there is major weewx update, weewx.conf is rewritten and our translations will disappear. I already have an issue when translating wind directions, changing W by O. So now, I try to not translate this file when possible.

poblabs commented 5 years ago

Yes this has been reported. I have not gotten to it yet - have been busy and have had no time to work on this since this is just a hobby.

Your assumption is also incorrect. Put all overrides in weewx.conf.

skin.conf gets overwritten on skin upgrades.

poblabs commented 5 years ago

Latest commit should close this one out.

poblabs commented 5 years ago

@HoracioDos I just separated out those high/low areas too. Should be all set now for you to translate them

bonjour81 commented 5 years ago

Sorry for double report!!! :( I guess I was too tired to think straight

HoracioDos commented 5 years ago

@HoracioDos I just separated out those high/low areas too. Should be all set now for you to translate them

Thank again Pat.

HoracioDos commented 5 years ago

Hello Pat. I synched your last commits (apr 27) and everything works fine with the new tags. I translated moon phases names and now the icon is missing in Sun & Moon. I think that I missed to config something else. Any hint? Thanks!

poblabs commented 5 years ago

@HoracioDos Hmm. this will be interesting. The moon icon is hard set. It gets the data from moon_phases and compares it to the almanac. So in order for that to work I wonder if I need to add a label for each moon phase, which will then be compared against moon_phases? Seems redundant though.

HoracioDos commented 5 years ago

Yes, I agree. It seems redundant, but if you have multiple skins, belchertown tags won't be affected if you have your own moon phases names. I found that Moon-container is duplicated in style.css

.moon-container {
    font-size:15px;
}
.moon-container {
    color:#808080;
}
bonjour81 commented 5 years ago

@HoracioDos : did you translate moon phases in weewx.conf too ? I did this before, but I think it's what the skin uses to find the right icon. it shall stay in english here. I mean in weewx.conf in:

[StdReport]
    [[Defaults]]   
             [[[Almanac]]]

english moon phases in weewx.conf but french in skin.conf (in [almanach] works for me.

olpayras commented 5 years ago

I only translate weewx.conf, and its ok for me.

In french :

[[[Almanac]]]

            # The labels to be used for the phases of the moon:
            moon_phases = Nouvelle, Croissante, Premier quartier, Gibbeuse croissante, Pleine, Gibbeuse décroissante, Dernier Quartier, Décroissante
HoracioDos commented 5 years ago

Hello bonjour81 and olpayras. When you translate moon phases names to french, moon phases icons are lost. The only way to get the icons is keeping moon phases in english.

HoracioDos commented 5 years ago

Hello Pat! Is there an axis label for wind rose? I would like to translate Frequency (%). Thanks!

HoracioDos commented 5 years ago

Hi. Don't worry! I found it in belchertown.js.tmpl. I see that I can translate the ordinal directions too.

poblabs commented 5 years ago

Hi, this should be something I need to add. We don't want to edit tmpl files since they will be replaced on upgrades. I will have to work on this.

Sent from mobile

On Mon, Apr 29, 2019, 11:04 AM HoracioDos notifications@github.com wrote:

Hi. Don't worry! I found it in belchertown.js.tmpl. I see that I can translate the ordinal directions too.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/poblabs/weewx-belchertown/issues/104#issuecomment-487616620, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2SYZ5SXLQOG47PXIAXP53PS4E7PANCNFSM4HHSYFQQ .

bonjour81 commented 5 years ago

Ordinal direction are also defined in weewx.conf in [[[[Ordinates]]]]

Maybe it can be redefined in skin.conf for translation?

poblabs commented 5 years ago

@HoracioDos the Frequency label is now available to be translated in the 1.0rc8 release.

HoracioDos commented 5 years ago

I'll sync tonight. Thanks Pat!

HoracioDos commented 5 years ago

I updated to rc8 two hours ago. Everything seems to be fine. Complete station_observations are = "barometer", "visibility", "cloudbase", "dewpoint", "outHumidity", "rainWithRainRate", "UV", "radiation" in weewx.conf Thanks! PS: Frequency is OK now. LOL!

bonjour81 commented 5 years ago

Hi! There is something a bit strange, not really translation issue,but it's linked. In record table, alltime: "Consecutives days without rain" => 8 days | November 23 - December 1, 2016

In French, I have: 12 jours | octobre 12 - 24 octobre 2018 It's all in french, but we do not say "octobre 12", we would rather say "12 octobre". I assume it's a mater of time formatting string. Not sure how to solve this easily.

HoracioDos commented 5 years ago

My records page is fine. Días Consecutivos sin Lluvia | 1 días | Fin: 15 de abril de 2019 These are my settings in weewx.conf belchertown_locale = "es_AR.UTF-8" time_records_page_full_date = "lll" time_records_page_month_day_year = "LL" time_records_page_rainfall_range_begin = "MMMM DD" time_records_page_rainfall_range_end = "LL"

bonjour81 commented 5 years ago

Thanks, I'll check this!

HoracioDos commented 5 years ago

Hello. Check this https://momentjs.com/docs/ if you want something else. Here you will find all moments options

HoracioDos commented 5 years ago

Hi This is an old issue that I forgot to comment when we began to translate. These keywords seem to have some problem with its encoding. For example: letter ó is shown as &#243 which is correct for an ó.

encoding

olpayras commented 5 years ago

Seems having same issue than HoracioDos here :

# Manifest Settings
    manifest_name = "Mon site météo"
    manifest_short_name = "MWW"

The é are translated with chars looking like previous picture on my smartphone

and here

# DarkSky translations
        alert_in_effect             = à partir de
        forecast_last_updated       = Mise à jour le

Capture du 2019-05-07 14-35-11

HoracioDos commented 5 years ago

Hello Pat Jquery is your thing. he who knows, knows!

poblabs commented 5 years ago

Thanks! Still trying to figure out the Manifest settings though. Last commit should fix the DarkSky and Last Updated lines.

HoracioDos commented 5 years ago

It looks good!

poblabs commented 5 years ago

@olpayras I haven't been able to find a fix for this without changing a config setting. But if you go to skin.conf and change [CheetahGenerator] --> encoding = html_entities to encoding = utf8 it will fix your Manifest.

I do not know what else this may break though!

poblabs commented 5 years ago

I knew this was going to happen. I spent an hour researching this. I knew once I updated this issue I would find the fix.

Update your skin.conf with the one I just committed, and restart weewx. It'll force utf8 on the manifest file.

HoracioDos commented 5 years ago

That's how the mind works. It quite frustrating many times

salinois commented 5 years ago

hello bonjour81, here salinois, I am also french, and I had translate some files for skin Belchertown. Patrick

olpayras commented 5 years ago

Hi Salinois,

I've also forked a french translation. I'm working on 1.0rc8 translation. Here's my french translation on 1.0rc7. Just copy files labelled French Translation. They include my fork for adding history feature, you can optonnaly remove items for my history feature or not. For labels who arent translated, you should have to modifiy on weewx.conf, like barometer, dewpoint etc...

Re : I see your website is on 0.9, so you will have a lot of pain to translate it in french, because this release had a lot item who where to be modified in templates directly. I advice you to install Realase candidate from development branch. I'm working on french translation. I'll post a translation asap.

poblabs commented 5 years ago

@HoracioDos Try the latest commit file and see if it brings back your moon icon?

HoracioDos commented 5 years ago

Thanks Pat! Moon icon is back! moon_phases

olpayras commented 5 years ago

Good in french too. Good job !!!

@HoracioDos I Don't have the text down Moon Phase and sun. How can I have it ? Perhaps cause pyephem isn't installed on my developpement machine ?

HoracioDos commented 5 years ago

Hello Pat I realized that visibility has a point instead of comma 10.01 KM for today and It should be 10,01 Km. Json shows "visibility": "10,01 km" Thanks!

HoracioDos commented 5 years ago

Hello Olivier. I'm sorry! Ups!! I read your comment in a hurry. It is a customization I made. Pat is evaluating to show some info like that, I think it will arrive to the skin, sooner or later. If you want it right now look into my fork, but I would wait for the official version.

olpayras commented 5 years ago

I found some hard coded labels in header.tmpl.html : see below please :

Capture

@HoracioDos Oh nice, that's a good idea. I'll look in your fork. Tks.