pobrn / mktorrent

A simple command line utility to create BitTorrent metainfo files
Other
474 stars 72 forks source link

Use a designated initializer list for the initialization of the metafile object #21

Closed ghost closed 4 years ago

Rudde commented 4 years ago

Your commit seems very incomplete.

esmil commented 4 years ago

It's technically correct, as in it doesn't change behaviour of the code since all remaining fields are automatically zero-initialized once you use just one designated initializer.

However, I think what Rudde means is that there may be value in keeping the explicit zero initialization of the other fields for documentation/readability reasons.

pobrn commented 4 years ago

Since the user account has been deleted, and there has been agreement that this pull request brings no benefit, I am closing it.