search

pobrn / mktorrent

A simple command line utility to create BitTorrent metainfo files
Other
472 stars 73 forks source link

#include changes and header files for multiple source files #39

Closed uno20001 closed 4 years ago

uno20001 commented 4 years ago

This commit changes how files are included when ALLINONE is defined to make extending this functionality to new source files easier. A new export.h has been created to enable easier use of the EXPORT macro. Furthermore, header files have been created for init.c, output.c, and the hashing related source files.

esmil commented 4 years ago

This is probably fine, I haven't looked into it much, but if it was up to me I'd just get rid of the ALLINONE feature completely. That should simplify the code and make it more maintainable/malleable for the future.

As mentioned issue #38 you can get a similar effect in a much nicer way by simply compiling with -flto.

uno20001 commented 4 years ago

if it was up to me I'd just get rid of the ALLINONE feature completely

Certainly, I did this to simplify extending this functionality should it be desirable to be kept.