search

poise / poise-python

A Chef cookbook to provide a unified interface for installing Python, managing Python packages, and creating virtualenvs.
Apache License 2.0
124 stars 108 forks source link

ubuntu 18.04 support #116

Closed dennybaa closed 6 years ago

dennybaa commented 6 years ago

Hi there, fails on bionic, please check.

/root/.chef/local-mode-cache/cache/cookbooks/poise-languages/files/halite_gem/poise_languages/system/mixin.rb:

 80:          end
 81:  
 82:          # Find the first value on system_package_candidates that is in system_packages.
 83:          system_package_candidates(options['version'].to_s).each do |name|
 84:            return name if system_packages.include?(name)
 85:          end
 86:          # No valid candidate. Sad trombone.
 87>>         raise PoiseLanguages::Error.new("Unable to find a candidate package for version #{options['version'].to_s.inspect}. Please set package_name provider option for #{new_resource}.")
 88:        end
coderanger commented 6 years ago

There was some initial support in 1.7 but the full fix landed in master yesterday https://github.com/poise/poise-python/commit/861bf06e69131510c49fa5e35869bdba9fb7aabd

jeffbyrnes commented 6 years ago

@coderanger would you please publish a release that incorporates this fix?

coderanger commented 6 years ago

@jeffbyrnes Asking for a release is almost never a good plan. I will get to it when I get to it.