Introduces a new final state

politie / sherlock

A reactive programming library for JavaScript applications, built with TypeScript.

Apache License 2.0

39 stars 12 forks source link

Introduces a new final state #178

Closed pavadeli closed 5 years ago

coveralls commented 5 years ago

Coverage decreased (-0.03%) to 99.548% when pulling a452bf4ab54fda4d74b04f75bfc86b637955fdc5 on new-final-state into a00f51a423d14d897516db293869a8b6267d5811 on master.

pavadeli commented 5 years ago

This will probably also have effect on things like from/to Observable. That will happen in a separate PR, I presume?

Good one. Created issue #179 that tracks that.

pavadeli commented 5 years ago

This will probably also have effect on things like from/to Observable. That will happen in a separate PR, I presume?

Good one. Created issue #179 that tracks that.

🤦‍♂ This is already default behavior. Added a test that confirms that. Note that fromObservable should not be changed because it can re-subscribe to its Observable after it has completed.