The type of the reaction parameter of Derivable.react() has changed from (value: V) => void to (value: V, stop: () => void) => void. The type of the same parameter of DerivableProxy.$react() does still not include the stop() function as a parameter.
This does not usually cause much trouble, but it is a bug, and causes compilation errors when using the ValuePipe from @politie/ngx-sherlock on DerivableProxys.
Proposed fix: add the stop() function parameter to DerivableProxy.$react's reaction parameter.
The type of the
reaction
parameter ofDerivable.react()
has changed from(value: V) => void
to(value: V, stop: () => void) => void
. The type of the same parameter ofDerivableProxy.$react()
does still not include thestop()
function as a parameter.This does not usually cause much trouble, but it is a bug, and causes compilation errors when using the
ValuePipe
from @politie/ngx-sherlock onDerivableProxy
s.Proposed fix: add the
stop()
function parameter toDerivableProxy.$react
'sreaction
parameter.