search

polyswarm / ppdns-chrome-extension

MIT License
1 stars 0 forks source link

[FIX 7078] better error messages #48

Closed alanjds closed 2 weeks ago

alanjds commented 2 weeks ago

Better handling of errors, and more informative error messages. Most of them include the last day that an ingestion worked, and they all mention that failed data will be stored to be retried later.

alanjds commented 2 weeks ago

@mjbradford89 Thanks for the updates.

Some of the titles became too big for one line. I changed these from "We had an issue submitting" to "Could not submit" and "There is an issue connecting" to "Could not connect".

Could you please take another look?

mjbradford89 commented 2 weeks ago

hey @alanjds I think these changes look good. But I am having an issue when testing. When I install the extension and enter an API key, the request that validates it returns a 500 so the key is not validated correctly. I think this is probably because the /v3/instance endpoint works differently than v2 :cry:.

image

mjbradford89 commented 2 weeks ago

I created a pr that should fix the 500 error in AI. Hopefully this will fix the issue with the api key validation and no more changes are needed here.

alanjds commented 2 weeks ago

I created a pr that should fix the 500 error in AI. Hopefully this will fix the issue with the api key validation and no more changes are needed here.

I will revert the v2 -> v3 change. During my tests, v2 was working good

alanjds commented 2 weeks ago

hey @alanjds I think these changes look good. But I am having an issue when testing. When I install the extension and enter an API key, the request that validates it returns a 500 so the key is not validated correctly. I think this is probably because the /v3/instance endpoint works differently than v2 😢.

image

@mjbradford89 I changed back to v2 in a828803. Please take another look.