popsim-consortium / adding-species-manuscript

manuscript materials for the adding species paper
3 stars 14 forks source link

Bos Taurus paragraph and other edits #25

Closed gregorgorjanc closed 2 years ago

gregorgorjanc commented 2 years ago

Here is the Bos Taurus paragraph and a number of other edits - hopefully an improvement ;)

lauterbur commented 2 years ago

Unless you want to change anything before I do, I will go ahead and merge these so I can do all-over edits.

lauterbur commented 2 years ago

I don't think Bos taurus needs any more cuts/major edits for now. We'll see how things flow with the rest once we have the conclusion. Thanks for the edits elsewhere too, very helpful!

gregorgorjanc commented 2 years ago

@lauterbur yeah merge this in! Thanks! Sorry for dragging my feet!

One comment though - we need something similar for all other added species too, right?

lauterbur commented 2 years ago

I think that's overkill, one example for why a species might be of general interest, and how to pick parameter values, is probably enough since this is now a more general "how to do a popgen simulation" paper rather than a "uses of stdpopsim" paper

gregorgorjanc commented 2 years ago

OK, I was thinking the same, just wasn’t sure if the direction of travel.

With regards, Gregor

On Mon, Apr 11 2022 at 7:03 pm, M. Elise Lauterbur @.***> wrote:

I think that's overkill, one example for why a species might be of general interest, and how to pick parameter values, is probably enough since this is now a more general "how to do a popgen simulation" paper rather than a "uses of stdpopsim" paper

— Reply to this email directly, view it on GitHub https://github.com/popsim-consortium/adding-species-manuscript/pull/25#issuecomment-1095365477, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFRGSXNWITTRGTRKKW3WT3VERSPBANCNFSM5TBWJEAQ . You are receiving this because you authored the thread.Message ID: @.*** com>