popsim-consortium / adding-species-manuscript

manuscript materials for the adding species paper
3 stars 14 forks source link

whole-genome simulations #77

Closed grahamgower closed 1 year ago

grahamgower commented 1 year ago

The abstract touts stdpopsim as providing whole-genome simulations. This is also discussed at the end of the introduction, plus the section titled "the utility of \stdpopsim for genome-wide simulations". This gives the strong impression that stdpopsim does whole-genome simulations. A reader might then be somewhat surprised to then learn that they can only do single-chromosome simulations with stdpopsim!

igronau commented 1 year ago

I think that we're trying to avoid explicitly discussing the delta between whole-chrom simulations and whole-genome simulations. I guess we can/should be more careful about this distinction without having to add a detailed discussion about this issue. I think that some instances of 'whole-genome' could/should be replaced with 'whole-chromosome', and we can at least add one sentence saying that a major step in producing whole-genome simulation is enabling simulations of chromosome-length sequences. @grahamgower - do you think it's also important to explicitly say what we're missing out by separately (and independently) modeling each chromosome?

grahamgower commented 1 year ago

I don't think it's necessary to discuss the distinction between whole-genome simulations and whole-chromosome simulations. But I do think it's important to not mislead the reader here.

igronau commented 1 year ago

Okay. I think that the correct balance should treat whole-genome simulations as the ultimate goal of stdpopsim, but not say that it currently achieves this. When we explicitly discuss what stdpopsim provides, we should use 'whole-chromosome' instead of 'whole-genome'. I'll scan the manuscript and make these adjustments.

igronau commented 1 year ago

I address this in PR #79. I basically left only two mentions of "whole-genome simulations": one in the abstract and one in the beginning of the discussion. The context there is the ultimate objective of stdpopsim, so I think that in this context it make sense. I replaced all other instances with "chromosome-scale simulations", which appears to be the more appropriate term. This includes a switch in the title of the section following the introduction.

I think that this is a good move, but I'm a bit afraid that a casual reader might find "chromosome-scale" too technical, while "whole-genome" is a more familiar term (even if not fully accurate). So I'm interested in what other think about this switch. @lauterbur, @jeromekelleher, @petrelharp , @andrewkern?

lauterbur commented 1 year ago

I'm fine with it either way.

On Mon, Oct 3, 2022 at 12:06 PM igronau @.***> wrote:

I address this in PR #79 https://github.com/popsim-consortium/adding-species-manuscript/pull/79. I basically left only two mentions of "whole-genome simulations": one in the abstract and one in the beginning of the discussion. The context there is the ultimate objective of stdpopsim, so I think that in this context it make sense. I replaced all other instances with "chromosome-scale simulations", which appears to be the more appropriate term. This includes a switch in the title of the section following the introduction.

I think that this is a good move, but I'm a bit afraid that a casual reader might find "chromosome-scale" too technical, while "whole-genome" is a more familiar term (even if not fully accurate). So I'm interested in what other think about this switch. @lauterbur https://github.com/lauterbur, @jeromekelleher https://github.com/jeromekelleher, @petrelharp https://github.com/petrelharp , @andrewkern https://github.com/andrewkern?

— Reply to this email directly, view it on GitHub https://github.com/popsim-consortium/adding-species-manuscript/issues/77#issuecomment-1265901926, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTKUNM27MHXYNYVHVZESMLWBMVDJANCNFSM6AAAAAAQ3MGP7M . You are receiving this because you were mentioned.Message ID: @.*** com>

petrelharp commented 1 year ago

This sounds good to me (I don't mind "chromosome-scale".)

jeromekelleher commented 1 year ago

Chromosome-scale is a good phrase I think, and I agree "whole-genome" would be misleading.