Closed MattWellie closed 4 months ago
Updated to include that version change, now shoving a cheeky patch bump on top for this change
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.15%. Comparing base (
5451b07
) to head (9b1633d
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issue
The backoff-retry decorator is working, but my original suggestion probably wasn't enough. See Batch driver image. Relevant logging:
This failing metamist query ran 3 times, stopping for barely a second in between attempts. On the plus side, the exception catch-backoff ran as intended, but from the backoff docstring:
I can't really square the behaviour I've seen (3 attempts, combining for < 2 seconds total wait) with the code as implemented which should be doing unlimited retries up to a 10 second gap. Unless the next interval after 1.1s was > 10s, which is not impossible... and would explain the gap.
This Change
This is just a suggestion PR, might have been better phrased as an Issue: the current backoff implementation is working, just not working well enough.