Closed illusional closed 4 months ago
Attention: Patch coverage is 77.36721%
with 98 lines
in your changes are missing coverage. Please review.
Project coverage is 77.15%. Comparing base (
8ee989f
) to head (83eb562
). Report is 2 commits behind head on dev.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @EddieLF! Yeah, a bit of extra refactoring here to bring it in line with other classes. Yep, all your points are exactly correct! I've made a few changes per your suggestions, and to improve code coverage on some of the things I've changed (resulting in more changes).
I'm going to merge this one after #615, because I'll need to update a few things that I've changed here - so if you want to re-review, feel free to do it after that. Let me know if you're not comfy with approving this (though I think you're in a great position too :) ).
Thanks for the review!
I got carried away, but broadly:
Will self-review, then assign out soon.