populationgenomics / metamist

Sample level metadata system
MIT License
1 stars 1 forks source link

OurDNA: Improve project table view and filtering #742

Closed illusional closed 2 months ago

illusional commented 4 months ago

OurDNA RFC: https://docs.google.com/document/d/1bG8oZQdhA3lEeqlvnCZ1n_P1OqaqDBPlMPB7oz275ns/edit#heading=h.sxmryphgwrnn

Aims:

Consider:

Actual changes:

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 88.01653% with 145 lines in your changes missing coverage. Please review.

Project coverage is 79.79%. Comparing base (8124a13) to head (65dc8e9).

Files Patch % Lines
db/python/filters/generic.py 85.00% 30 Missing :warning:
api/routes/web.py 70.96% 27 Missing :warning:
db/python/tables/participant.py 80.21% 18 Missing :warning:
models/models/web.py 81.70% 15 Missing :warning:
test/test_web.py 87.17% 15 Missing :warning:
db/python/layers/web.py 87.64% 11 Missing :warning:
db/python/tables/sample.py 82.45% 10 Missing :warning:
db/python/tables/sequencing_group.py 89.58% 5 Missing :warning:
db/python/layers/participant.py 84.61% 2 Missing :warning:
db/python/layers/seqr.py 60.00% 2 Missing :warning:
... and 8 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #742 +/- ## ========================================== + Coverage 79.15% 79.79% +0.63% ========================================== Files 161 168 +7 Lines 13622 14127 +505 ========================================== + Hits 10782 11272 +490 - Misses 2840 2855 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

illusional commented 2 months ago

Having some issues with the Form component in the ValueFilter, when it's wrapped in a Form, the sizing doesn't work correctly, but if it's removed I can't catch the "on enter" event.

image