search

populationgenomics / metamist

Sample level metadata system
MIT License
1 stars 1 forks source link

OurDNA: Dashboard Backend #750

Closed nevoodoo closed 2 months ago

nevoodoo commented 4 months ago

Description

This PR adds the backend logic that aggregates the data needed for the OurDNA Dashboard UI.

See: https://docs.google.com/spreadsheets/d/1crEwZhFMD-m0sO4TGm-8FcwsFxGhg_IIyPB5yH2O7Q0/edit?usp=sharing

Changes

nevoodoo commented 4 months ago

@vivbak @illusional I have moved the ourdna field to the GraphQLProject type, and removed the nullable checks like was suggested, and there is a project permissions check being made by the layer so I have removed it from the schema level for now. Keen to hear what you think, I have tested to make sure the query works as intended locally :)

vivbak commented 3 months ago

To Action: https://github.com/populationgenomics/metamist/pull/766#discussion_r1604073456

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 95.59585% with 17 lines in your changes missing coverage. Please review.

Project coverage is 77.83%. Comparing base (ab809cd) to head (dc98692). Report is 6 commits behind head on dev.

:exclamation: Current head dc98692 differs from pull request most recent head 36b48be

Please upload reports for the commit 36b48be to get more accurate results.

Files Patch % Lines
db/python/layers/ourdna/dashboard.py 94.64% 9 Missing :warning:
api/graphql/schema.py 73.91% 6 Missing :warning:
test/test_ourdna_dashboard.py 98.79% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #750 +/- ## ========================================== + Coverage 77.30% 77.83% +0.53% ========================================== Files 157 160 +3 Lines 13010 13396 +386 ========================================== + Hits 10057 10427 +370 - Misses 2953 2969 +16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.