populationgenomics / metamist

Sample level metadata system
MIT License
1 stars 1 forks source link

Improving error handling for ETL notifications #761

Closed milo-hyben closed 4 months ago

milo-hyben commented 4 months ago

This PR is fixing issue when failed ETL load was not passed to slack alert channel. Reason was the message contained the whole stacktrace and failed during message formatting. To prevent this reason for failure has been shortened to only first 100 chars, BQ table still contain the whole message useful for debugging.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 77.13%. Comparing base (affbe6f) to head (fb7e606).

Files Patch % Lines
etl/load/main.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #761 +/- ## ========================================== - Coverage 77.15% 77.13% -0.02% ========================================== Files 157 157 Lines 12950 12952 +2 ========================================== Hits 9991 9991 - Misses 2959 2961 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.