search

populationgenomics / metamist

Sample level metadata system
MIT License
1 stars 1 forks source link

Add pseudo contributor role w/o readonly reqs, but write access #777

Closed illusional closed 4 months ago

illusional commented 4 months ago

Short term hack for: https://github.com/populationgenomics/metamist/pull/703

  1. Check readonly
  2. Then update the connection to make it non-readonly.

Though this gently points out that someone could update the connection.readonly attribute to False anywhere in the code, maybe this should be frozen.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 77.08%. Comparing base (60d67d1) to head (c43a157).

Files Patch % Lines
api/utils/db.py 22.22% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #777 +/- ## ========================================== - Coverage 77.12% 77.08% -0.04% ========================================== Files 157 157 Lines 12957 12967 +10 ========================================== + Hits 9993 9996 +3 - Misses 2964 2971 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.