Assorted Cohort Fixes - Githubissues

vivbak commented 2 months ago

Cohort -> Project and CohortTemplate -> Project were previously not working. This PR defines the project_id on the GraphQLCohort and GraphQLCohortTemplate objects, so that it can be correctly passed to the loader. It also creates the project field on the GraphQLCohortTemplate.
You could not correctly filter for cohort template ids, due to a type mismatch. This PR fixes the type defined for the template_id.

vivbak commented 2 months ago

FYI @MattWellie

vivbak commented 2 months ago

Note: Unit tests are currently failing due to a known issue https://github.com/populationgenomics/metamist/pull/792

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 77.03%. Comparing base (58a95f2) to head (46c1dc8).

Files	Patch %	Lines
api/graphql/schema.py	44.44%	5 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #793 +/- ## ========================================== - Coverage 77.04% 77.03% -0.02% ========================================== Files 157 157 Lines 13060 13067 +7 ========================================== + Hits 10062 10066 +4 - Misses 2998 3001 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

populationgenomics / metamist

Assorted Cohort Fixes #793

Codecov Report