codecov-commenter
commented
2 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 77.03%. Comparing base (
6c37b9a) to head (74d17b4).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## dev #801 +/- ## ======================================= Coverage 77.03% 77.03% ======================================= Files 157 157 Lines 13068 13069 +1 ======================================= + Hits 10067 10068 +1 Misses 3001 3001 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The changes introduced in https://github.com/populationgenomics/metamist/pull/757 were to bring fields from the assay meta into the sequencing group meta, for sequencing groups created from assays where
technology == long-read.The unfortunate side effect was that this also added the fields to the sg meta:
sequencing_technology,sequencing_type,sequencing_platform. These are top-level required fields for all sequencing group records, so duplicating these fields in the meta makes no sense. This was a total oversight on my part.This PR adds those three fields to the list of fields to exclude when porting the assay meta to the sequencing group meta, for long-read assays.