search

populationgenomics / metamist

Sample level metadata system
MIT License
1 stars 1 forks source link

Empty Cohorts Silently Fail #807

Open vivbak opened 1 month ago

vivbak commented 1 month ago

Resulting in an issue in production pipelines https://github.com/populationgenomics/production-pipelines/issues/776

Cohorts are constructed with 'AND' like criteria, and as such it's very easy to get an empty cohort as output.

We may not want to allow cohorts to be created when there are no sequencing groups within them.

We may also want to restrict the values to be valid, however, the same issue may exist, as valid criteria can still produce empty cohorts.

Point of discussion in prod-pipes meeting.

MattWellie commented 1 month ago

We may not want to allow cohorts to be created when there are no sequencing groups within them.

This feels pretty key for me, I don't see a purpose in creating a cohort with no usability. In that sense I think this is twinned with https://github.com/populationgenomics/production-pipelines/issues/776